fix: resolve 10 code review issues

High priority:
- Fix concurrent race condition for view_count/like_count (atomic update)
- Add route request ID tracking to prevent race conditions
- Filter get_joke by status=approved (no pending content leak)
- Add error feedback for like button

Performance:
- Optimize random joke query (avoid full table sort)
- Limit page_size max to 100 (DoS prevention)

Medium:
- Add localStorage quota error handling
- Handle empty AI response gracefully
- Fix generate content title extraction

Low:
- Add rejected_jokes to stats API
- Update dashboard to show rejected count
This commit is contained in:
bwstudio
2026-06-02 20:35:08 +08:00
parent 0b43973236
commit ceed63fcb0
144 changed files with 191660 additions and 270 deletions
+4 -1
View File
@@ -1,5 +1,8 @@
from app.models.joke import Joke
from app.models.category import JokeType, JokeCrowd
from app.models.user import AdminUser
from app.models.setting import AiSetting
from app.models.link import Link
from app.models.feedback import Feedback
__all__ = ["Joke", "JokeType", "JokeCrowd", "AdminUser"]
__all__ = ["Joke", "JokeType", "JokeCrowd", "AdminUser", "AiSetting", "Link", "Feedback"]
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
+13
View File
@@ -0,0 +1,13 @@
from sqlalchemy import Column, Integer, String, Text, DateTime
from sqlalchemy.sql import func
from app.database import Base
class Feedback(Base):
__tablename__ = "feedbacks"
id = Column(Integer, primary_key=True, autoincrement=True)
name = Column(String(50), nullable=True)
email = Column(String(100), nullable=True)
content = Column(Text, nullable=False)
created_at = Column(DateTime, default=func.now())
+3
View File
@@ -12,6 +12,9 @@ class Joke(Base):
id = Column(Integer, primary_key=True, autoincrement=True)
title = Column(String(200), nullable=False)
content = Column(Text, nullable=False)
polished_content = Column(Text, nullable=True)
type_ids = Column(Text, nullable=True)
crowd_ids = Column(Text, nullable=True)
type_id = Column(Integer, ForeignKey("joke_types.id"), nullable=True)
crowd_id = Column(Integer, ForeignKey("joke_crowds.id"), nullable=True)
status = Column(String(20), default="pending")
+14
View File
@@ -0,0 +1,14 @@
from sqlalchemy import Column, Integer, String, DateTime
from sqlalchemy.sql import func
from app.database import Base
class Link(Base):
__tablename__ = "links"
id = Column(Integer, primary_key=True, autoincrement=True)
name = Column(String(100), nullable=False)
url = Column(String(500), nullable=False)
description = Column(String(200), nullable=True)
sort_order = Column(Integer, default=0)
created_at = Column(DateTime, default=func.now())
+23
View File
@@ -0,0 +1,23 @@
from sqlalchemy import Boolean, Column, DateTime, Float, Integer, String, Text, func
from app.database import Base
class AiSetting(Base):
__tablename__ = "ai_settings"
id = Column(Integer, primary_key=True, autoincrement=True)
provider = Column(String(50), nullable=False, default="nvidia")
api_base = Column(String(500), nullable=False, default="https://integrate.api.nvidia.com/v1")
api_key = Column(String(500), nullable=False, default="")
model_name = Column(String(100), nullable=False, default="nvidia/llama-3.1-nemotron-70b-instruct")
temperature = Column(Float, nullable=False, default=0.7)
max_tokens = Column(Integer, nullable=False, default=2048)
crawl_enabled = Column(Boolean, nullable=False, default=False)
crawl_keywords = Column(Text, nullable=True, default="")
max_pages_per_run = Column(Integer, nullable=False, default=3)
is_active = Column(Boolean, nullable=False, default=True)
created_at = Column(DateTime, default=func.now())
updated_at = Column(DateTime, default=func.now(), onupdate=func.now())