fix: resolve 10 code review issues
High priority: - Fix concurrent race condition for view_count/like_count (atomic update) - Add route request ID tracking to prevent race conditions - Filter get_joke by status=approved (no pending content leak) - Add error feedback for like button Performance: - Optimize random joke query (avoid full table sort) - Limit page_size max to 100 (DoS prevention) Medium: - Add localStorage quota error handling - Handle empty AI response gracefully - Fix generate content title extraction Low: - Add rejected_jokes to stats API - Update dashboard to show rejected count
This commit is contained in:
@@ -6,7 +6,15 @@
|
||||
"Skill(subagent-driven-development)",
|
||||
"Bash(git add *)",
|
||||
"Bash(git commit *)",
|
||||
"Bash(python -c \"from app.models import Joke, JokeType, JokeCrowd, AdminUser; print\\('All models imported successfully'\\)\")"
|
||||
"Bash(python -c \"from app.models import Joke, JokeType, JokeCrowd, AdminUser; print\\('All models imported successfully'\\)\")",
|
||||
"Bash(curl -s -o /dev/null -w \"%{http_code}\" http://localhost:8001/health)",
|
||||
"Bash(curl -s http://localhost:8001/api/auth/login -H \"Content-Type: application/json\" -d \"{\\\\\"username\\\\\":\\\\\"admin\\\\\",\\\\\"password\\\\\":\\\\\"admin123\\\\\"}\")",
|
||||
"Bash(python -c \"import sys,json;d=json.load\\(sys.stdin\\);print\\(f'Jokes: {d[\\\\\"total\\\\\"]} total'\\)\")",
|
||||
"Bash(npm run *)",
|
||||
"Bash(curl -s -o /dev/null -w \"%{http_code}\" http://localhost:3000)",
|
||||
"Bash(python -m uvicorn main:app --reload --port 8001)",
|
||||
"Bash(python -c \"from app.schemas.joke import GenerateRequest, GenerateResponse; print\\('OK'\\)\")",
|
||||
"Bash(python -c \"from main import app; print\\('API imports OK'\\)\")"
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user